Git & Commit Guidelines
This guide covers Git setup and commit message conventions for TimeTiles.
Quick Setup
make setup # Configures commit template and hooksThis automatically sets up:
- Commit message template (
.gitmessage) - Pre-commit hooks (lint, typecheck via Husky)
- Commit message validation (commitlint)
Commit Message Format
<type>(<scope>): <subject>
<body>Understanding Type vs Scope
Before diving into the format, it’s crucial to understand:
- Type = WHAT kind of change you’re making (the nature of the change)
- Are you adding features? →
feat - Fixing bugs? →
fix - Adding tests? →
test
- Are you adding features? →
- Scope = WHERE in the codebase (the area affected)
- In which feature? →
(import),(geocoding) - In which app/package? →
(web),(docs) - In which layer? →
(api),(db)
- In which feature? →
Example: fix(import): handle empty CSV files
- What: Fixing a bug (
fix) - Where: In the import feature (
import)
Title (Required)
The title is the first line of your commit message and must:
- Be no more than 72 characters
- Start with a type and optional scope
- Use the imperative mood (“add” not “adds” or “added”)
- Not end with a period
Type
The type must be one of the following:
Feature & Fixes:
- feat: A new feature for the user (not a new feature for build script)
- Example:
feat(import): add support for Excel file uploads
- Example:
- fix: A bug fix for the user (not a fix to a build script)
- Example:
fix(geocoding): handle addresses with special characters
- Example:
Code Quality:
- refactor: Code changes that neither fix bugs nor add features
- Example:
refactor(api): extract validation logic into middleware
- Example:
- format: Code formatting changes (whitespace, missing semicolons, indentation)
- Example:
format(ui): fix indentation in button component - Note: This is ONLY for code formatting, not CSS/UI styling changes
- Example:
- perf: Performance improvements
- Example:
perf(import): reduce memory usage by streaming CSV files
- Example:
Testing & Documentation:
- test: Adding missing tests or correcting existing tests
- Example:
test(events): add unit tests for date validation
- Example:
- docs: Documentation only changes
- Example:
docs(api): update endpoint examples with new fields
- Example:
Maintenance & Operations:
- build: Changes affecting build system or external dependencies
- Example:
build(deps): upgrade to Next.js 15 - Example:
build: optimize webpack configuration
- Example:
- ci: CI/CD pipeline and workflow changes
- Example:
ci: add automated security scanning - Example:
ci(web): configure E2E tests in pipeline
- Example:
- chore: Other changes that don’t modify src or test files
- Example:
chore: update seed data generation
- Example:
Special Types:
- revert: Reverts a previous commit
- Example:
revert: feat(import): add Excel support - Body should include:
This reverts commit <hash>
- Example:
- security: Security fixes or improvements
- Example:
security(auth): fix JWT token expiration issue - Example:
security(import): add file type validation
- Example:
Scope (Intelligently Optional)
The scope provides additional context about what part of the codebase changed.
When scope can be omitted:
- When the type already indicates the scope (avoiding redundancy)
docs: update README(when changing documentation files)ci: fix GitHub Actions(when changing CI/CD files)build: update Docker config(when changing build files)test: add unit tests(when changing test files)
When scope is recommended:
- When the type doesn’t clearly indicate what area is affected
fix(import): handle empty CSV files(not justfix:)feat(geocoding): add address caching(not justfeat:)refactor(api): extract middleware(not justrefactor:)
Scopes are organized into categories:
Monorepo Packages & Apps (where the code lives):
- web: Next.js web application (apps/web)
- docs: Documentation site (apps/docs)
- ui: Shared UI components package
- assets: Shared assets package (logos, images)
- config: Configuration packages (ESLint, TypeScript, Prettier) - ONLY for packages/*-config/
Core Features (what functionality is affected):
- import: File import system (CSV/Excel processing, scheduled imports, webhook triggers)
- geocoding: Address geocoding and location services
- events: Event data management (including catalogs and datasets)
- schema: Schema detection, validation, and versioning
- deploy: User deployment features (self-hosting, Docker setup)
- quota: Quota management and rate limiting
- access: Access control and permissions
- cache: Caching systems (HTTP, URL fetch, etc.)
- webhooks: Webhook functionality
- admin: Admin panel features
- auth: Authentication and user sessions
- media: Media and file management
Technical Areas (infrastructure & tooling):
- db: Database operations, migrations, PostGIS
- api: API endpoints (REST)
- jobs: Background job processing and queues
- deps: Dependencies and package management
- seed: Test and development data generation
- test: Testing infrastructure and test files
Infrastructure (build & CI/CD):
- ci: GitHub Actions, CI/CD pipelines
- build: Docker, build configuration, Turbo
- infra: Infrastructure and DevOps
⚠️ Important Scope Rules:
- The
configscope is ONLY for configuration packages (packages/eslint-config, packages/prettier-config, packages/typescript-config) - For CI/CD files (.github/), use
ciscope, notconfig - For build configuration (Dockerfile, Makefile), use
buildscope - The system will validate your scope matches the files you’re changing
Subject
The subject contains a succinct description of the change:
- Use the imperative mood
- Start with lowercase (proper nouns allowed: GitHub, PostgreSQL, TypeScript, etc.)
- No period at the end
- Be clear and concise
Body (Optional but Recommended)
The body should use bullet points to clearly describe the changes. Use verbosity scaling based on the complexity of your changes:
When to Include a Body
Title-only commits (no body needed):
- Simple, self-explanatory changes
- Single-file formatting fixes
- Minor typos or corrections
- Dependency updates without breaking changes
- Examples:
fix(import): prevent duplicate events,format(ui): fix code formatting
Commits with bodies (bullet points recommended):
- Multiple related changes in one commit
- Complex logic changes requiring explanation
- New features with multiple aspects
- Bug fixes that needed investigation
- Performance improvements with measurable impact
- Breaking changes (always require explanation)
Body Format Guidelines
- Start each point with a dash (-)
- Keep each bullet point concise and focused (one concept per bullet)
- Use as many bullet points as needed to fully describe the changes
- Include context about why changes were made when it’s not obvious
- Avoid unnecessary formatting (Git tools don’t render markdown well)
- Use plain text with minimal formatting for maximum compatibility
- Mark breaking changes with “BREAKING CHANGE:” as a separate paragraph
Wrap the body at 100 characters per line.
Examples
Simple Fix
fix(import): handle empty CSV files gracefullyFeature with Description
feat(schema): implement smart field type detection
- Added pattern recognition for common field types
- Detects dates, coordinates, URLs automatically
- Provides confidence scores for type suggestions
- Reduces manual schema configuration by 80%
- Supports incremental learning from user correctionsBreaking Change
refactor(api): change import endpoint response format
- Changed /api/import/upload response structure
- Now returns complete job object instead of just import ID
- Includes detailed progress tracking information
- Adds support for real-time status updates
- Improves error reporting with structured error objects
BREAKING CHANGE: API clients need to update to handle the new
response format. The import ID is now at response.job.importId
instead of response.importId.Multiple Changes
fix(web): correct type errors and improve error handling
- Fixed TaskStatus type in import-integration tests
- Added proper error boundaries to import components
- Improved error messages for failed geocoding attempts
- Updated error logging to include more context
- Added retry logic for transient failuresRefactoring with Context
refactor(geocoding): simplify provider initialization
- Extracted provider configuration to separate modules
- Removed duplicate validation logic across providers
- Consolidated error handling into base provider class
- Improved type safety with stricter interfaces
- Reduced initialization time from ~200ms to ~50msBug Fix with Investigation Details
fix(import): resolve memory leak in large file processing
- Identified leak in CSV parser stream handling
- Fixed by properly closing streams after processing
- Added explicit garbage collection hints for large batches
- Reduced memory usage by ~60% for files over 100MB
- Added monitoring to detect future memory issuesWriting Quality Commit Messages
Good commit messages tell a story about your changes. They should be written for future maintainers (including yourself) who need to understand the reasoning behind changes.
Mechanical vs. Thoughtful Approach
❌ Mechanical (just listing what changed):
fix(import): update import-jobs.ts and add validation
- Modified fileParsingJob function
- Added new validation checks
- Updated error handling code
- Changed batch processing logic✅ Thoughtful (explaining why and impact):
fix(import): prevent memory leaks in large file processing
- Added stream cleanup to prevent memory accumulation
- Implemented batch size limits for files over 100MB
- Enhanced error recovery to handle partial failures gracefully
- Reduced memory usage by 60% for large CSV importsFocus on Business Value
❌ Technical details without context:
refactor(geocoding): extract provider logic into separate classes
- Created GoogleProvider class
- Created NominatimProvider class
- Updated GeocodingService to use new providers
- Modified tests to work with new structure✅ Business value with technical context:
refactor(geocoding): improve provider extensibility for future integrations
- Extracted provider logic into pluggable classes
- Enables easy addition of new geocoding services
- Standardized error handling across all providers
- Reduced provider initialization time by 40%Formatting and Text Styling
Since Git tools (GitHub, GitLab, terminal git log, etc.) have varying markdown support, keep formatting minimal:
✅ Good formatting practices:
- Use plain text for maximum compatibility
- Bullet points with simple dashes (-)
- ALL CAPS for emphasis when needed (e.g., “BREAKING CHANGE:”)
- Simple parentheses for examples: (fixes #123)
- Avoid bold, italic, or other markdown formatting in commit messages
❌ Avoid in commit messages:
- Bold text - not consistently rendered
- Italic text - not consistently rendered
Code blocks- can appear as plain text with backticks- Links - become plain text in many git tools
- Complex formatting that relies on markdown parsing
Exception: These guidelines (this documentation) use markdown formatting for readability, but actual commit messages should be plain text.
Choosing the Right Type
When deciding between types, consider:
- feat vs fix: Is this adding new functionality (feat) or correcting existing behavior (fix)?
- fix vs refactor: Does this change user-facing behavior (fix) or just code structure (refactor)?
- build vs chore: Does this affect how the project builds (build) or is it general maintenance (chore)?
- build vs ci: Is this about build tooling (build) or CI/CD pipelines (ci)?
- format vs refactor: Is this only formatting (format) or restructuring code logic (refactor)?
- security vs fix: Is this addressing a security vulnerability (security) or a general bug (fix)?
Scope Selection Guide
When choosing a scope, follow these guidelines:
❌ Avoid: fix(web): fix import validation
✅ Prefer: fix(import): fix CSV validation
Use app/package scopes (web, docs, ui, assets, config) when:
- Changes are app/package-specific configuration
- Changes don’t fit any feature scope
- Changes span multiple features
Use feature scopes (import, geocoding, events, schema, deploy) when:
- Working on specific feature logic
- Fixing feature-specific bugs
- Adding feature-specific tests
Use technical scopes (db, api, jobs, deps, seed) when:
- Working on infrastructure
- Making technical improvements
- Updating dependencies
Note: Avoid overly granular scopes. For example:
- Docker changes → use
deploy(if user-facing) orbuild(if internal) - Script changes → use the scope of what the script affects
- Type changes → use the feature scope the types belong to
Handling Type/Scope Overlaps
The commitlint rules intelligently handle redundant type/scope combinations:
When scope can be omitted (type matches expected scope):
docs:- When changing documentation filesci:- When changing CI/CD configuration filesbuild:- When changing build configuration filestest:- When changing test files
When scope is still useful:
docs(web):- Documenting the web app specificallydocs(api):- API documentation updatestest(import):- Tests for the import featureci(deploy):- CI changes for deployment workflows
Special case - docs(docs):
docs(docs):- Valid when documenting the docs app itself- Example:
docs(docs): update Nextra configuration guide - This is NOT redundant because it’s about the documentation site code/config
- Example:
test(web): Use for adding tests to web app- Example:
test(web): add unit tests for import flow
- Example:
test(import): Use for adding tests to specific features- Example:
test(import): add CSV validation tests
- Example:
citype: Use for CI/CD pipeline changes- Example:
ci: update GitHub Actions workflow - Example:
ci(web): add E2E tests to deployment
- Example:
build(deps)vschore(deps):- Use
build(deps)for production dependencies - Use
chore(deps)for development-only dependencies
- Use
formattype: For code formatting only, NOT CSS/visual changes- CSS/visual changes:
feat(ui): update button styles - Code formatting:
format(api): fix indentation
- CSS/visual changes:
Best Practices
- Atomic Commits: Each commit should represent one logical change
- Focus on “Why” Not “What”: Explain the motivation and impact, not just what files changed
- ❌ Bad: “Updated GeocodingService.ts, added new provider, modified config”
- ✅ Good: “Add OpenCage provider for better European address coverage”
- Use Bullet Points: Structure your commit body with clear, concise bullet points
- Be Specific: Each bullet point should describe a specific change or aspect
- Avoid Mechanical Descriptions: Don’t just list file changes or technical details
- ❌ Bad: “Modified 3 files, added 2 functions, updated 1 test”
- ✅ Good: “Implement rate limiting to prevent API quota exhaustion”
- Choose the Right Scope:
- Use app/package scopes for changes isolated to that codebase
- Use feature scopes for business logic changes
- Use technical scopes for infrastructure/tooling changes
- When changes span multiple areas, pick the primary scope
- Test Your Changes: Ensure tests pass before committing
- Review Before Push: Use
git diff --stagedto review changes - Amend When Needed: Use
git commit --amendfor small fixes to the previous commit - Reference Issues: Include issue numbers when applicable (e.g., “fixes #123”)
- Keep Bullets Focused: One concept per bullet point for clarity
Enforcement and Validation
The project uses Husky and commitlint to enforce commit message standards. If your commit doesn’t meet the guidelines, it will be rejected with a helpful error message.
Automatic Scope Validation
The commit linting system includes intelligent scope validation that:
- Detects the correct scope based on the files you’re changing
- Suggests appropriate scopes if you use the wrong one
- Validates type-scope combinations to prevent common mistakes
- Enforces scope rules (e.g.,
configonly for package configurations)
Testing Commit Messages
You can test your commit messages before committing:
# Test a commit message
pnpm tsx scripts/validate-commit.ts "feat(web): add new feature"
# Test with specific files
pnpm tsx scripts/validate-commit.ts --files apps/web/app/page.tsx "fix: update homepage"
# Run validation test suite
pnpm tsx scripts/validate-commit.ts --testCommon Validation Errors
-
Wrong scope for CI files:
- ❌
fix(config): update CI workflow - ✅
fix(ci): update CI workflow - ✅
ci: update CI workflow(when type and scope would be the same)
- ❌
-
Redundant type(scope) combinations:
- ❌
ci(ci): update GitHub Actions→ Useci: - ❌
test(test): add unit tests→ Usetest(web):ortest(docs): - ❌
build(build): update webpack→ Usebuild: - ✅
docs(docs): update README for docs app(valid - documenting the docs app)
- ❌
-
Using
configfor non-package configs:- ❌
chore(config): update .gitignore - ✅
chore(build): update .gitignore
- ❌
-
Missing scope when files suggest one:
- ❌
fix: update import validation(when changing apps/web/app/api/import/) - ✅
fix(import): update validation
- ❌
-
Dependencies with wrong scope:
- ❌
chore(web): update dependencies(when changing package.json) - ✅
chore(deps): update dependencies
- ❌
Quick Reference
Title-only commits (for simple, self-explanatory changes):
# Scope omitted when type matches the context:
docs: update README with installation instructions
ci: update GitHub Actions to Node 24
build: optimize webpack configuration
test: add unit tests for date utilities
# Scope included for clarity:
fix(import): prevent duplicate event creation
docs(api): update geocoding endpoint examples
format(ui): fix button component indentation
chore(deps): update ESLint to latest version
test(events): add unit tests for event validation
fix(geocoding): resolve memory leak in location cache
feat(events): add bulk export functionality
perf(geocoding): implement request batching
security(api): fix request validation vulnerability
security(import): add file type validation to prevent malicious uploadsWhen to use title-only:
- Single-file changes with obvious intent
- Formatting fixes
- Simple dependency updates
- Minor documentation corrections
- Clear bug fixes that don’t need explanation
Commits with bullet-point bodies:
feat(web): add dark mode toggle
- Added theme context provider for global state
- Implemented toggle component in header
- Persisted user preference to localStorage
- Updated all components to use theme-aware colorsperf(import): optimize batch processing
- Increased default batch size from 100 to 500
- Added streaming parser for large CSV files
- Implemented parallel processing for geocoding
- Reduced memory allocation by reusing buffers
- Improved overall import speed by ~40%feat(web): add GraphQL API with ES module support
- Implemented GraphQL endpoint at /api/graphql
- Added ES module configuration for better tree-shaking
- Integrated with existing REST API authentication
- Supports both HTTP POST and WebSocket connectionsScope Selection Examples
# App/Package scope - when changes are isolated to one codebase
fix(ui): correct button hover state in dark mode
docs(docs): update getting started guide
format(config): fix ESLint configuration formatting
# Feature scope - when changing business logic
feat(events): add recurring event support
fix(geocoding): handle postal codes without city names
perf(import): optimize CSV parsing for large files
feat(schema): add automatic type detection for date fields
fix(import): handle scheduled import retry logic
feat(quota): add per-user rate limiting
feat(access): implement role-based permissions
refactor(cache): optimize URL fetch cache eviction
feat(webhooks): add retry logic for failed webhook deliveries
feat(admin): add user quota management interface
fix(auth): resolve session timeout edge case
feat(media): add image compression on upload
# Technical scope - for infrastructure/tooling
build: optimize production bundle size
test(api): add integration tests for event endpoints
ci: automate release notes generation
ci: add automated dependency vulnerability scanning
chore(seed): update test data with new event types
feat(deploy): add one-click Docker deployment
docs(deploy): document self-hosting requirements
# Handling overlaps correctly
docs(docs): update Nextra to version 3.0 # Docs app code change
refactor(web): reorganize test utilities # Test infrastructure
build(deps): upgrade PostgreSQL client to v16 # Production dependency
chore(deps): update ESLint to latest version # Dev dependency
security(import): add virus scanning for uploads # Security feature
format(config): fix TypeScript config formatting # Code formattingCommon Mistakes to Avoid
1. Listing File Changes
❌ Bad: "Updated GeocodingService.ts, modified config.ts, added tests"
✅ Good: "Add rate limiting to prevent geocoding API quota exhaustion"2. Technical Details Without Context
❌ Bad: "Add new function processCoordinates() and refactor validation logic"
✅ Good: "Improve coordinate validation to handle edge cases and malformed data"3. Using Present Tense Instead of Imperative
❌ Bad: "Adding support for Excel imports"
✅ Good: "Add support for Excel imports"4. Vague or Generic Messages
❌ Bad: "Fix bug" or "Update code" or "Improvements"
✅ Good: "Fix memory leak in CSV parser for files over 100MB"5. Too Much Technical Detail
❌ Bad: "Refactor AbstractGeocodingProvider to implement IGeocoder interface with async/await pattern"
✅ Good: "Standardize geocoding provider interface for easier testing and maintenance"6. Missing Business Context
❌ Bad: "Add new provider class and update service configuration"
✅ Good: "Add OpenCage provider to improve geocoding accuracy for European addresses"Remember: Good commit messages help future maintainers (including yourself) understand why changes were made, not just what changed. Focus on business value and user impact rather than technical implementation details.
Troubleshooting
Commit Rejected
Read the error message carefully. Common issues:
- Subject too short (minimum 10 characters)
- Invalid type or scope
- Vague terms like “stuff” or “things”
- Missing format
type(scope): subject
Editor Not Opening
Set your preferred editor:
git config --global core.editor "code --wait" # VS Code
git config --global core.editor "vim" # Vim
git config --global core.editor "nano" # NanoBypassing Hooks (Emergency Only)
git commit --no-verify -m "emergency: fix critical issue"Use sparingly - hooks maintain code quality.